Add Drizzle Select benchmark #2
Conversation
|
Hey @rphlmr, thanks so much for taking the time to create this PR, that's really appreciated! 🙏 The benchmarks in this repo specifically have been created to compare the performance of ORMs, i.e. higher-level APIs that abstract away from SQL. Since your PR uses Drizzle's lower-level SQL query builder API, it doesn't really fit the comparison in this repo and would lead to an Apple-to-Orange comparison (this is similar reasoning that was used in the Drizzle benchmarks to not merge our improvement using a raw query). That being said, we're planning to re-run the benchmarks again in a few months and will consider adding a comparison for the lower-level APIs of the ORMs as well, in which case we'd happily include your contribution! We'll leave the PR open until then! |
|
Thanks for the feedback 🙏 You are right! Do not hesitate to ping me back to update this PR once you are ready to integrate your new lower-level SQL API 👀 |
Yes, these sound like useful improvements — thank you! |
👋 As we discussed on X, this PR adds Drizzle with select benchmarks.
I have also made some minor fixes.
You will notice that I have added two indexes.
I know you explained why, but it really matters for Drizzle Query API on large datasets.
I am open to rolling back this change (it also increases Prisma performance 🚀)